fix: 지원 가능 대학 모집 인원 nullable 응답 처리 by yoonc01 · Pull Request #794 · solid-connection/solid-connect-server

yoonc01 · 2026-06-25T13:55:33Z

작업 내용

지원 가능 대학 응답 DTO의 studentCapacity 타입을 int에서 Integer로 변경했습니다.
모집 인원이 null인 지원 가능 대학 조회 시 NullPointerException이 발생하던 문제를 수정했습니다.

coderabbitai · 2026-06-25T13:55:49Z

Walkthrough

UnivApplyInfoDetailResponse의 studentCapacity 타입이 int에서 Integer로 변경되었습니다.
UnivApplyInfoPreviewResponse의 studentCapacity 타입이 int에서 Integer로 변경되었습니다.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

Gyuhyeok99
wibaek
lsy1307

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	제목이 모집 인원 nullable 응답 처리라는 핵심 변경을 정확히 요약합니다.
Description check	✅ Passed	관련 이슈와 작업 내용이 포함되어 있어 템플릿의 핵심 요구를 충분히 충족합니다.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/nullable-student-capacity-response

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

src/main/java/com/example/solidconnection/university/dto/UnivApplyInfoDetailResponse.java (1)
49-49: 🩺 Stability & Availability | 🟡 Minor

ApplicantsResponse 내의 원시형 int 선언이 여전히 NPE 위험을 안고 있어요. 🧐

안녕하세요! UnivApplyInfo 의 studentCapacity 가 Nullable(Integer) 인 점은 잘 파악하셨죠. 근데 형제 DTO 인 ApplicantsResponse 가 이 값을 받을 때만 또 달라졌어요. 바로 원시형 int 로 받고 있으라네요.

이 채를 그냥 두면, DB 에서 값이 비어 올 때 Integer 를 int 로 감쌈 (Unboxing) 하다가 '짜장면 스크래치'처럼 갑자기 NullPointerException 이 터져버릴 수 있어요. 따라서 같은 맥락에서 Integer 로 정리해 드려요.

현재 상태 — ApplicantsResponse 는 int studentCapacity로 선언 중입니다.

위험 요소 — null 이 넘어오면 감쌈 처리 중 예외가 발생합니다.

제안 사항 — 필드 타입을 Integer 로 변경하여 안전성을 확보합니다.
public record ApplicantsResponse(
        String koreanName,
        Integer studentCapacity,
        String region,
        String country,
        List<ApplicantResponse> applicants) {
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@src/main/java/com/example/solidconnection/university/dto/UnivApplyInfoDetailResponse.java`
at line 49, ApplicantsResponse still uses a primitive int for studentCapacity,
which can cause NPE during unboxing when UnivApplyInfo.getStudentCapacity() is
null. Update the ApplicantsResponse record to use Integer for studentCapacity
and keep the mapping in UnivApplyInfoDetailResponse aligned so the value is
passed through without primitive conversion.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In
`@src/main/java/com/example/solidconnection/university/dto/UnivApplyInfoDetailResponse.java`:
- Line 49: ApplicantsResponse still uses a primitive int for studentCapacity,
which can cause NPE during unboxing when UnivApplyInfo.getStudentCapacity() is
null. Update the ApplicantsResponse record to use Integer for studentCapacity
and keep the mapping in UnivApplyInfoDetailResponse aligned so the value is
passed through without primitive conversion.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: f1cc12a3-e6e8-42bf-8e6a-09feae15335f

📥 Commits

Reviewing files that changed from the base of the PR and between d7d866e and 7d3b40c.

📒 Files selected for processing (2)

src/main/java/com/example/solidconnection/university/dto/UnivApplyInfoDetailResponse.java
src/main/java/com/example/solidconnection/university/dto/UnivApplyInfoPreviewResponse.java

whqtker

고생하셨습니다 ! 이런 문제가 있었네요 ...

coderabbitai · 2026-06-25T14:03:25Z

Walkthrough

UnivApplyInfoDetailResponse의 studentCapacity 타입이 int에서 Integer로 변경되었습니다.
UnivApplyInfoPreviewResponse의 studentCapacity 타입이 int에서 Integer로 변경되었습니다.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

Gyuhyeok99
wibaek
lsy1307

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	제목이 모집 인원 nullable 응답 처리라는 핵심 변경을 정확히 요약합니다.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description check	✅ Passed	관련 이슈와 작업 내용이 포함되어 있어 템플릿을 전반적으로 충족하며, 일부 항목은 보완 가능하지만 큰 결함은 없습니다.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/nullable-student-capacity-response

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

fix: 지원 가능 대학 모집 인원 nullable 응답 처리

7d3b40c

yoonc01 self-assigned this Jun 25, 2026

yoonc01 requested review from Gyuhyeok99, whqtker and wibaek as code owners June 25, 2026 13:55

yoonc01 added the 버그 Something isn't working label Jun 25, 2026

yoonc01 requested review from Hexeong, JAEHEE25, lsy1307 and sukangpunch as code owners June 25, 2026 13:55

coderabbitai Bot reviewed Jun 25, 2026

View reviewed changes

whqtker approved these changes Jun 25, 2026

View reviewed changes

yoonc01 merged commit c695705 into develop Jun 25, 2026
4 checks passed

yoonc01 mentioned this pull request Jun 25, 2026

fix: nullable student capacity response #796

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: 지원 가능 대학 모집 인원 nullable 응답 처리#794

fix: 지원 가능 대학 모집 인원 nullable 응답 처리#794
yoonc01 merged 1 commit into
developfrom
fix/nullable-student-capacity-response

yoonc01 commented Jun 25, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jun 25, 2026 •

edited

Loading

❌ Failed checks (1 warning)

Uh oh!

coderabbitai Bot left a comment

Uh oh!

whqtker left a comment

Uh oh!

coderabbitai Bot commented Jun 25, 2026

❌ Failed checks (1 warning)

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

yoonc01 commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

관련 이슈

작업 내용

Uh oh!

coderabbitai Bot commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Estimated code review effort

Suggested reviewers

❌ Failed checks (1 warning)

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

whqtker left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot commented Jun 25, 2026

Walkthrough

Estimated code review effort

Suggested reviewers

❌ Failed checks (1 warning)

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

yoonc01 commented Jun 25, 2026 •

edited

Loading

coderabbitai Bot commented Jun 25, 2026 •

edited

Loading